Add redundant-assert checker for implied assert.Error assertions#310
Open
mmorel-35 wants to merge 3 commits into
Open
Add redundant-assert checker for implied assert.Error assertions#310mmorel-35 wants to merge 3 commits into
redundant-assert checker for implied assert.Error assertions#310mmorel-35 wants to merge 3 commits into
Conversation
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
30232fa to
ec75d69
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new checker to catch redundant
assert.Error/assert.Errorfcalls when a stronger error assertion on the same error expression already exists in the same block. The goal is to remove duplicate signal and keep error assertions minimal.New checker:
redundant-assertast.BlockStmt.assert.Error*when paired with a stronger assertion on the same error expression:ErrorContains*ErrorIs*ErrorAs*EqualError*analysisutil.NodeString) for same-error detection.Checker integration
redundant-assertin checker priority order and enables it by default.Docs and examples
redundant-assertto the README checker table.Analyzer test coverage
.go+.golden) for:assert.Error*+ stronger assertion on same error (diagnostic expected)assObj.Error)