Skip to content

Investigating [BUG] - Stream: Area detection hangs on PDF page #30 #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mikelor wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Investigating [BUG] - Stream: Area detection hangs on PDF page #30 #33

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Investigating [BUG] - Stream: Area detection hangs on PDF page #30
  • Loading branch information
@mikelor
mikelor committed Aug 6, 2024
commit 89fb0bab735a434a0324c352012427bb97a66244
7 changes: 5 additions & 2 deletions Tabula/Detectors/SimpleNurminenDetectionAlgorithm.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ public IReadOnlyList<TableRectangle> Detect(PageArea page)

bool foundTable;

do
// do
{
foundTable = false;

Expand Down Expand Up @@ -282,7 +282,10 @@ public IReadOnlyList<TableRectangle> Detect(PageArea page)
tableAreas.Add(table);
}
}
} while (foundTable);
// removed following line. It's unclear how this code exit's the loop. When a table is found,
// there is nothing to advance to the next set of criteria, so a table will always be found.
// } while (foundTable);
}

// create a set of our current tables that will eliminate duplicate tables
SortedSet<TableRectangle> tableSet = new SortedSet<TableRectangle>(new TreeSetComparer());
Expand Down