Fix compile errors preventing Cloudburst jar from compiling#168
Merged
Conversation
Kazzuk
approved these changes
Sep 20, 2025
Contributor
|
wow |
TheShermanTanker
force-pushed
the
compile
branch
from
60ab461 to
fd3c592
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cloudburst currently cannot be compiled at all due to 2 compile errors in NetworkUtils and PackManager. This patch fixes those errors and allows Cloudburst to be compiled again. Note: This will not allow you to create a runnable Cloudburst jar. The Cloudburst jar still remains broken, and will have to have a more in depth fix applied to it to function again (Coming soon)
The fixes here are simple, the constructor signatures have merely changed. ResourcePacksInfoPacket.Entry now takes a UUID directly as the first argument rather than a String version of the UUID, and has an additional cdn argument, which I set to an empty string for now. ItemStackResponseSlot now contains a profanity filtered version of the name, but seeing as we don't have a profanity filter and probably no one is going to implement one anytime soon, we'll just throw it an empty string to make the error go away. I actually wanted to implement a better fix for this since the profanity filtered name already is default initialized to an empty string, but lombok sadly isn't flexible enough and the all args constructor will demand that as an argument even if the field is already set...