Skip to content

make block palette and block registry not crash#30

Merged
Creeperface01 merged 5 commits into
feature/block-statesfrom
dev/make-block-palette-run
Aug 4, 2020
Merged

make block palette and block registry not crash#30
Creeperface01 merged 5 commits into
feature/block-statesfrom
dev/make-block-palette-run

Conversation

@DaMatrix

@DaMatrix DaMatrix commented Aug 3, 2020

Copy link
Copy Markdown
Member

No description provided.

@DaMatrix DaMatrix requested a review from SupremeMortal August 3, 2020 15:50
@DaMatrix

DaMatrix commented Aug 3, 2020

Copy link
Copy Markdown
Member Author

ouch, this is now crashing again. sorry, one second...

@DaMatrix

DaMatrix commented Aug 3, 2020

Copy link
Copy Markdown
Member Author

there we go, that works again. sorry for all the commit spam...

…ault values rather than taking the first one
@Creeperface01 Creeperface01 merged commit 1f7a62f into feature/block-states Aug 4, 2020
@DaMatrix DaMatrix deleted the dev/make-block-palette-run branch August 4, 2020 12:11
Kazzuk pushed a commit that referenced this pull request Feb 11, 2026
* make block palette and block registry not crash

* throw a TODO on BlockState#AIR

* add dedicated BlockStates class

* fix crashing a second time

* fix order of enum trait values and compute default state based on default values rather than taking the first one
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants