Scoreboard Support and API#66
Closed
lukeeey wants to merge 6 commits into
Closed
Conversation
MrReskill
previously approved these changes
Dec 30, 2020
Member
Author
|
I've removed the scoreboard command that i was working on (ill add it back in a future PR) and simply left the API |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally created by RednedEpic at CloudburstMC/Nukkit#1420
This brings in a scoreboard API (and eventually a finished system to interact with /scoreboard commands) to Cloudburst. For the time being, this PR will mostly only cover support for scoreboards (with an API to do so) that are the equivalent of that of what can be done in vanilla Bedrock itself, however, this may also include some additions that are slightly beyond the scope of vanilla Bedrock, such as adding support for multiple criteria and teams.
I also did what other parts of the codebase have done and split up the API and implementation for the scoreboards themselves. There are some parts of the code (such as the static builder methods in the API classes) which directly call on the impl classes. However when Cloudburst eventually does split up the API and implementation, adding in some sort of builder provider should be quite easy to do.
What's left to do:
/scoreboard command (working on)- in another PRPer-world scoreboards (for interacting with the scoreboard command)-in another PR