fix: the midifile library copies sysex and meta even... in midifile.c#19
Merged
CrazyCritic89 merged 1 commit intoMay 16, 2026
Conversation
Automated security fix generated by Orbis Security AI
Owner
|
Damn, I wasn't even thinking about potential security flaws in the libraries. Should've considering the age of this and how long it's been since its last update. Thank you for this! I'm planning on moving to fmidi soon if you want to look at that. Of course, this isn't set in stone, just an idea. I'll be merging this. Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix critical severity security issue in
midifile/midifile.c.Vulnerability
V-001midifile/midifile.c:2973Description: The midifile library copies sysex and meta event data into heap-allocated destination buffers using a data_length value read directly from the MIDI file, without verifying that data_length does not exceed the allocated size of the destination buffer. An attacker can craft a MIDI file where the declared event data length exceeds the actual allocated buffer, causing memcpy to write beyond the heap allocation boundary and corrupt adjacent heap memory.
Changes
midifile/midifile.cVerification
Automated security fix by OrbisAI Security