fix: correct GitHub URL regex pattern and add tests#2742
Open
sijie-Z wants to merge 1 commit into
Open
Conversation
|
@sijie-Z is attempting to deploy a commit to the DeepSource Team on Vercel. A member of the Team first needs to authorize it. |
The original regex used a character class [http://|https://] which would match individual characters like 'h', 't', 'p', etc. instead of the full protocol prefix. Replaced with proper non-capturing group (?:https?://)?. Also escaped the dot in github.com to prevent matching non-dot characters. Added unit tests for the regex covering: - Standard HTTPS URLs - HTTP URLs - URLs without protocol - Trailing slashes - Dots in owner/name - Non-GitHub URLs (no match) - Invalid strings (no match)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original regex used a character class [http://|https://] which would match individual characters like 'h', 't', 'p', etc. instead of the full protocol prefix. Replaced with proper non-capturing group (?:https?://)?.
Also escaped the dot in github.com to prevent matching non-dot characters.
Added unit tests for the regex covering: