Reader modernization step 1#1591
Draft
siliconfeces wants to merge 9 commits into
Draft
Conversation
siliconfeces
force-pushed
the
reader_dethicc
branch
2 times, most recently
from
1628214 to
50eac22
Compare
siliconfeces
force-pushed
the
reader_dethicc
branch
from
50eac22 to
5a17a07
Compare
siliconfeces
commented
Jun 13, 2026
Comment on lines
+126
to
+130
| $("#archive-title").empty().append(titleContainer); | ||
| $("#archive-title-overlay").empty().append(titleContainer.clone()); | ||
| } else { | ||
| $("#archive-title").text(state.content.title); | ||
| $("#archive-title-overlay").text(state.content.title); |
Contributor
Author
There was a problem hiding this comment.
Stuff like this is technically archive overlay-related and should rather end up there, but I'm thinking about handling that in follow-up PRs.
Does that sound reasonable?
siliconfeces
force-pushed
the
reader_dethicc
branch
from
7a80b0d to
6409261
Compare
Owner
|
Pausing this while #1214 gets thru |
siliconfeces
force-pushed
the
reader_dethicc
branch
from
6409261 to
e68ad67
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split up reader and start modernizing by using preact.
Initially this PR was only intended to split the reader into multiple files based on functionality, but has since expanded to also start migrating stuff to preact.
Switching between standard view mode and infinite view does no longer reload the page. Hopefully this have not introduced too many new bugs.
Attempts have been made to keep attribution, but may require some specific
git blamecalls to get that showing up and a squash merge will definitely break that.