Skip to content

Adds Julia as a plugin target for generating parsers#110

Merged
DmitrySoshnikov merged 15 commits into
DmitrySoshnikov:masterfrom
davidmclifton:add-julia-target
Mar 23, 2022
Merged

Adds Julia as a plugin target for generating parsers#110
DmitrySoshnikov merged 15 commits into
DmitrySoshnikov:masterfrom
davidmclifton:add-julia-target

Conversation

@davidmclifton

Copy link
Copy Markdown
Contributor

Tokenizer, Parser and some working example files. Additional details shared via email to Dmitry.

The generated Julia parser has one dependency - the very common DataStructures package which provides Queue and Stack implementations.

@DmitrySoshnikov DmitrySoshnikov left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start! Some comments are inline:

Comment thread src/plugins/julia/lr/lr-parser-generator-julia.js Outdated
Comment thread src/plugins/julia/julia-parser-generator-trait.js Outdated
Comment thread src/plugins/julia/templates/lr.template.jl
Comment thread src/plugins/julia/templates/lr.template.jl Outdated
Comment thread src/plugins/julia/templates/lr.template.jl Outdated
@davidmclifton

Copy link
Copy Markdown
Contributor Author

Committed changes per request comments

@DmitrySoshnikov DmitrySoshnikov left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great – thanks for the contribution!

Comment thread src/plugins/julia/templates/lr.template.jl
@DmitrySoshnikov DmitrySoshnikov merged commit 8a02920 into DmitrySoshnikov:master Mar 23, 2022
@DmitrySoshnikov

Copy link
Copy Markdown
Owner

We will also need to update main README file to add Julia language, and also add a specific README to Julia plugin directory, similar to the README from the Rust plugin.

@davidmclifton davidmclifton deleted the add-julia-target branch March 23, 2022 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants