Skip to content

Warning about capture characters #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DmitrySoshnikov merged 4 commits into from
Jun 25, 2022
Merged

Warning about capture characters #119

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f83dfa3
Added a warning when using location capture characters without the --…
misdocumeno Jun 23, 2022
d0b13e4
Added options object for dateFromGrammarFile method
misdocumeno Jun 24, 2022
e9c090a
More specific test
misdocumeno Jun 24, 2022
46d2537
Calls to dataFromGrammarFile updated
misdocumeno Jun 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Added options object for dateFromGrammarFile method
  • Loading branch information
@misdocumeno
misdocumeno committed Jun 24, 2022
commit d0b13e4715b6fa8248593cc9d60c72bc4d1e592c
5 changes: 4 additions & 1 deletion src/bin/syntax.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -554,7 +554,10 @@ function getGrammar(grammarFile, mode) {
return null;
}

const grammarData = Grammar.dataFromGrammarFile(grammarFile, 'bnf', options.loc);
const grammarData = Grammar.dataFromGrammarFile(grammarFile, {
Comment thread
misdocumeno marked this conversation as resolved.
grammarType: 'bnf',
useLocation: options.loc,
});

// If explicit lexical grammar file was passed, use it.
const lexGrammarData = getLexGrammarData(options);
Expand Down
4 changes: 2 additions & 2 deletions src/grammar/grammar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,11 +176,11 @@ export default class Grammar {
* Reads grammar file data. Supports reading `bnf`,
* and `lex` grammars based on mode.
*/
static dataFromGrammarFile(grammarFile, grammarType = 'bnf', loc = false) {
static dataFromGrammarFile(grammarFile, { grammarType = 'bnf', useLocation = false }) {
const grammar = fs.readFileSync(grammarFile, 'utf8');

// check if the bnf grammar contains location capture characters
if (grammarType === 'bnf' && !loc) {
if (grammarType === 'bnf' && !useLocation) {
const bnf = grammar
// lexer rules
.replace(/%lex[\n\s\S]*?\/lex/g, '')
Expand Down