feat: implement fine-tuned debounce settings#746
Merged
Conversation
Owner
|
@Luc-vr Thanks, I'll make a few more improvements to your code before I release it. Excellent work! :) |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in #744, CSS height or width transitions can cause severe animation jank. This is because the ResizeObserver fires on every frame and, by default, updates immediately to ensure responsiveness, causing layout thrashing.
This PR refactors the update.debounce option to support a fine-tuned object structure: { resize, mutation, event }.
This allows users to specifically debounce resize events (e.g., debounce: { resize: 333 }) to prevent jank during animations, while keeping mutations responsive.
To ensure current configurations don't break, this change is backwards compatible. Legacy inputs (passing a number or tuple directly) are preserved and automatically mapped to the mutation debounce to match previous behavior.