Skip to content

fix(app): fix ODDBackButton padding#20530

Closed
koji wants to merge 2 commits into
edgefrom
fix_AUTH-2681
Closed

fix(app): fix ODDBackButton padding#20530
koji wants to merge 2 commits into
edgefrom
fix_AUTH-2681

Conversation

@koji

@koji koji commented Jan 10, 2026

Copy link
Copy Markdown
Contributor

Overview

fix ODDBackButton padding

close AUTH-2681

Test Plan and Hands on Testing

  • push this to ODD or ODD mode
  • set up a protocol
  • tap Instruments

Changelog

  • update ODDBackButton padding

Review requests

Risk assessment

low

koji added 2 commits January 9, 2026 18:07
support forwardRef in withStyleProps

close AUTH-2672
fix ODDBackButton padding

close AUTH-2681
@codecov

codecov Bot commented Jan 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.55172% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 55.94%. Comparing base (e18d5aa) to head (4b1e805).
⚠️ Report is 8 commits behind head on edge.

Files with missing lines Patch % Lines
app/src/redux/protocol-runs/selectors/setup.ts 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #20530      +/-   ##
==========================================
- Coverage   55.94%   55.94%   -0.01%     
==========================================
  Files        3675     3675              
  Lines      311061   311066       +5     
  Branches    45834    45831       -3     
==========================================
- Hits       174025   174022       -3     
- Misses     136792   136806      +14     
+ Partials      244      238       -6     
Flag Coverage Δ
app 46.00% <96.55%> (+<0.01%) ⬆️
protocol-designer 19.50% <82.75%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
app/src/molecules/ODDBackButton/index.tsx 100.00% <100.00%> (ø)
components/src/hocs/withStyleProps.ts 100.00% <100.00%> (ø)
app/src/redux/protocol-runs/selectors/setup.ts 14.11% <0.00%> (ø)

... and 15 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sfoster1 sfoster1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's limit the changes to just what the PR title says - the changes to the getCameraUsageState selector may be right but let's put that in another pr, ditto the withStyleProps changes.

@koji koji marked this pull request as ready for review January 12, 2026 20:02
@koji koji requested a review from a team as a code owner January 12, 2026 20:02
@koji koji closed this Jan 12, 2026
@koji

koji commented Jan 12, 2026

Copy link
Copy Markdown
Contributor Author

This is not from CSS Modules migration and the component itself very old and need to swtich from backbutton to ChildNavigation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants