feat(monorepo): extend mainifold compatibility to accommodate direct wellplate#21639
Merged
Conversation
…e direct wellplate This PR extends the manifold to accommodate a collection plate directly (valid combination, bottom up: collectin plate, filter plate, collar)
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## edge #21639 +/- ##
=======================================
Coverage 21.62% 21.62%
=======================================
Files 3907 3907
Lines 320262 320276 +14
Branches 57770 57779 +9
=======================================
+ Hits 69246 69272 +26
+ Misses 248046 248034 -12
Partials 2970 2970
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
… are transparent in the middle; update vacuum hardware sim slightly
ncdiehl11
changed the title
jerader
reviewed
Jun 11, 2026
Comment on lines
+54
to
+58
| (movingLabwareIsFilterPlate && | ||
| !adapterIsLid && | ||
| !adapterIsTiprack && | ||
| !adapterIsFilterPlate) || | ||
| (adapterIsVacuumSpacer && movingLabwareIsCollar) || |
Collaborator
There was a problem hiding this comment.
oof lol, i guess not much we can do to make it more readable though
Collaborator
Author
There was a problem hiding this comment.
yeah it's so gross but these are the rules for movement
jerader
approved these changes
Jun 11, 2026
jerader
left a comment
jerader
left a comment
Collaborator
There was a problem hiding this comment.
nice! left a few comments, all mild though
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR extends the logic to accommodate the full range of possible labware and adapter combinations on both the main manifold area and dock.
Also, I add 5 new labware definitions for filter plates to be used in the system. NOTE: these definitions are defined to physical spec, but their display names, loadnames, and volumes are subject to change.
Closes EXEC-2404
Test Plan and Hands on Testing
vacuum_labware_test.py
PD starting deck — valid labware matrix
Changelog
List changes introduced by this PR considering future developers and the end user. Give careful thought and clear documentation to breaking changes.
Review requests
Risk assessment
medium. touches a lot of core PD deck setup files, but generally branches on vacuum module special logic so as to not disrupt existing logic for non-vacuum labware loads