chore(js): Show only lint errors, not warnings, by default#21721
Merged
Conversation
SyntaxColoring
requested review from
a team and
ncdiehl11
and removed request for
a team
sfoster1
approved these changes
Jun 11, 2026
sfoster1
left a comment
sfoster1
left a comment
Member
There was a problem hiding this comment.
ty! want to also bump the heap memory restrictions?
koji
reviewed
Jun 11, 2026
| # todo(mm, 2026-03-04): Move --report-unused-disable-directives-severity to config file | ||
| # when the file supports it (upgrade eslint and/or move away from legacy config format) | ||
| pnpm exec eslint --quiet=$(quiet) --report-unused-disable-directives-severity error --ignore-pattern "node_modules/" ".*.@(js|ts|tsx)" "**/*.@(js|ts|tsx)" | ||
| NODE_OPTIONS="--max-old-space-size=8192 $(NODE_OPTIONS)" pnpm exec eslint --quiet=$(quiet) --report-unused-disable-directives-severity error --ignore-pattern "node_modules/" ".*.@(js|ts|tsx)" "**/*.@(js|ts|tsx)" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
quietdecides whether our JS linter emits just errors (quiet=true), or also warnings (quiet=false).We have thousands of warnings, which is too many for
quiet=falseto be a useful default, so this switches the default toquiet=true.Test Plan and Hands on Testing
None needed.
Review requests
Agreed, in principle?
Risk assessment
Low.