fix(step-generation): correctly grab single well from well sets in ROW configuration#21740
Merged
Merged
Conversation
…W configuration This PR fixes a bug in the `getTargetTipsFromWellSets` utility through which nested lists of wells passed to liquid handling functions are reduced to a flat list of target wells. Closes RQA-5623
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## chore_release-pd-9.0.0 #21740 +/- ##
=======================================================
Coverage 21.70% 21.70%
=======================================================
Files 3926 3926
Lines 328120 328114 -6
Branches 59858 59852 -6
=======================================================
Hits 71226 71226
+ Misses 253913 253907 -6
Partials 2981 2981
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes a bug in the
getTargetTipsFromWellSetsutility through which nested lists of wells passed to liquid handling functions are reduced to a flat list of target wells.Closes RQA-5623
Test Plan and Hands on Testing
Changelog
No transposition is needed for ROW configuration well sets; rather, we should just grab the first well of each set to target (example: input rows
[[H1, H2, ..., H12], [G1, G2, ..., G12]]should return[H1, G1]Review requests
see test plan
Risk assessment
low. fixes a bug existing in prod