Skip to content

fix(step-generation): correctly grab single well from well sets in ROW configuration#21740

Merged
ncdiehl11 merged 1 commit into
chore_release-pd-9.0.0from
pd_fix-row-wells
Jun 15, 2026
Merged

fix(step-generation): correctly grab single well from well sets in ROW configuration#21740
ncdiehl11 merged 1 commit into
chore_release-pd-9.0.0from
pd_fix-row-wells

Conversation

@ncdiehl11

Copy link
Copy Markdown
Collaborator

Overview

This PR fixes a bug in the getTargetTipsFromWellSets utility through which nested lists of wells passed to liquid handling functions are reduced to a flat list of target wells.

Closes RQA-5623

Test Plan and Hands on Testing

  • import protocol attached to the ticket
  • in step 8, navigate to final page of form (tip settings)
  • select manual tip seletion, and select a valid set of tips
  • save and verify no timeline error

Changelog

No transposition is needed for ROW configuration well sets; rather, we should just grab the first well of each set to target (example: input rows [[H1, H2, ..., H12], [G1, G2, ..., G12]] should return [H1, G1]

Review requests

see test plan

Risk assessment

low. fixes a bug existing in prod

…W configuration

This PR fixes a bug in the `getTargetTipsFromWellSets` utility through which nested lists of wells
passed to liquid handling functions are reduced to a flat list of target wells.

Closes RQA-5623
@ncdiehl11 ncdiehl11 self-assigned this Jun 12, 2026
@ncdiehl11 ncdiehl11 requested review from jerader and koji June 12, 2026 19:39
@ncdiehl11 ncdiehl11 marked this pull request as ready for review June 12, 2026 19:39
@codecov

codecov Bot commented Jun 12, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 21.70%. Comparing base (9c278f5) to head (38a3cb3).
⚠️ Report is 1 commits behind head on chore_release-pd-9.0.0.

Files with missing lines Patch % Lines
step-generation/src/utils/safePipetteMovements.ts 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           chore_release-pd-9.0.0   #21740   +/-   ##
=======================================================
  Coverage                   21.70%   21.70%           
=======================================================
  Files                        3926     3926           
  Lines                      328120   328114    -6     
  Branches                    59858    59852    -6     
=======================================================
  Hits                        71226    71226           
+ Misses                     253913   253907    -6     
  Partials                     2981     2981           
Flag Coverage Δ
protocol-designer 39.55% <0.00%> (+<0.01%) ⬆️
step-generation 60.75% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
step-generation/src/utils/safePipetteMovements.ts 44.26% <0.00%> (+0.36%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mjhuff mjhuff left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love to see it.

@ncdiehl11 ncdiehl11 merged commit 248af5c into chore_release-pd-9.0.0 Jun 15, 2026
20 of 21 checks passed
@ncdiehl11 ncdiehl11 deleted the pd_fix-row-wells branch June 15, 2026 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants