(modified from EMC) add disable-give-dropping#106
Merged
Conversation
Member
|
The setting should probably be |
Author
|
@notOM3GA yea, Billy just said that in the discord server. I will do that right now! |
Titaniumtown
changed the title
Author
|
The config and patch has been renamed in accordance with the comments made by @BillyGalbreath and @notOM3GA |
katekerllenevich
requested changes
Dec 2, 2020
katekerllenevich
approved these changes
Dec 2, 2020
BillyGalbreath
approved these changes
Dec 2, 2020
Member
|
Remember to squash lol |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an config option
settings.disable-give-dropping(that is disabled by default) to disable/givespewing out items if the target player's inventory is full. This is taken from https://github.com/starlis/empirecraft/blob/master/patches/server/0057-Fix-Give-command.patch but is simply modified to add a config option that controls it inpurpur.ymlI tested this without any issues.