Add Language API#1142
Merged
Merged
Conversation
BillyGalbreath
approved these changes
Oct 2, 2022
encode42
approved these changes
Oct 2, 2022
YouHaveTrouble
approved these changes
Oct 2, 2022
katekerllenevich
approved these changes
Oct 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds a Language API to translate translation keys and Translatables into the default server language, along with checking if a translation key can be translated. This is useful for cases where it isn't possible to use text components, but you still need a Translatable turned into human readable text.
Without this API, to translate translation keys you would need to either use NMS, or use the adventure plain text serializer. However, the plain text serializer needs wrapping the translation key into a TranslatableComponent then running the serializer on it, while having this API would make it a simple method call which goes to an ImmutableMap access. It was also not possible to check if a given translation key could be translated with the plain text serializer.