feat: Cure effects food property#1146
Closed
RealRONiN wants to merge 7 commits into
Closed
Conversation
Author
|
I'm not sure what to do with this, |
BillyGalbreath
suggested changes
Oct 6, 2022
BillyGalbreath
left a comment
BillyGalbreath
left a comment
Contributor
There was a problem hiding this comment.
I just woke up, so I hope I got it all in one go ^_^
Removed previous honey bottle patches to include cure effect property in food properties so any food item can use it.
RealRONiN
changed the title
Author
|
Technically, milk bukket should be a food item, should I add it to |
from 21608 characters to 9759; over 54% of characters were removed. from 304 lines long to 160; 47% of lines were removed.
granny
approved these changes
Oct 25, 2022
granny
left a comment
granny
left a comment
Member
There was a problem hiding this comment.
PR is ready to merge. Waiting on Billy in case he wants to make any changes.
BillyGalbreath
suggested changes
Oct 26, 2022
BillyGalbreath
left a comment
BillyGalbreath
left a comment
Contributor
There was a problem hiding this comment.
This is far from ready. I will rewrite it myself when I get back online.
encode42
added
the
needs-docs
Member
|
Closing as it doesn't seem like there will be any progress done anytime soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Honey bottles can cure any effect same as milk bukkets, it can also heal a player and add additional potion effects if any specified.
IRL Honey has numerous benefits, it'd make sense if it serves more benefits than just the saturation effect.