Add option to disable scissor damage in liquid#1295
Merged
Conversation
|
things that modify behavior are typically disabled by default |
Contributor
|
That is true! The current defaults would result in an unexpected behavior change; scissors no longer doing damage in water. Easy fix though! |
|
Yeah! thank you for contributing to Purpur to make it more awesome 🌋 |
Member
Author
|
Fixed! |
granny
requested changes
Mar 21, 2023
granny
left a comment
granny
left a comment
Member
There was a problem hiding this comment.
Looks good to me! It looks like you're checking both water & lava but the option is labeled as "water". My request is to create a separate option specifically for lava as well.
Member
Author
|
Fixed it! There are now two options |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added an option to disable scissor damage while in liquid. Some people found it annoying that they take damage when swimming clearing kelp. Made it optional just in case people like to get stabbed while swimming. It is enabled by default, think most players would not like it to be enabled
This is my first PR, please let me know if I did anything wrong. Sorry about the previous PR too, was trying to fix something and accidentally deleted it which closed the PR