Stored Bee API#1339
Closed
EOT3000 wants to merge 1 commit into
Closed
Conversation
Member
|
I like this, unfortunately your timings is just off. You'll have to rebase this onto 1.20, I'm too tired to review this tonight but I'll take a look at it later. |
granny
requested changes
Jun 10, 2023
Comment on lines
+15
to
+16
| +import org.jetbrains.annotations.Nullable; | ||
| +import org.purpurmc.purpur.entity.StoredEntity; |
Comment on lines
+65
to
+67
| - private static class BeeData { | ||
| + // Purpur - change from private to public | ||
| + public static class BeeData { |
| import java.util.List; | ||
| import net.minecraft.core.BlockPos; | ||
| import net.minecraft.world.entity.Entity; | ||
| +import net.minecraft.world.level.Level; |
Member
There was a problem hiding this comment.
doesn't look like this is being used anywhere?
Comment on lines
+90
to
+93
| +import org.jetbrains.annotations.NotNull; | ||
| +import org.jetbrains.annotations.Nullable; | ||
| +import org.purpurmc.purpur.entity.PurpurStoredBee; | ||
| +import org.purpurmc.purpur.entity.StoredEntity; |
Contributor
Author
|
I don't understand how github works too well so I'll make another PR with all the requested changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a way to modify some properties of individual stored entities (bees in beehive), as well as release them individually, without having to release them all.