Skip to content

Stored Bee API#1343

Merged
granny merged 6 commits into
PurpurMC:ver/1.20.1from
EOT3000:ver/1.20
Jun 26, 2023
Merged

Stored Bee API#1343
granny merged 6 commits into
PurpurMC:ver/1.20.1from
EOT3000:ver/1.20

Conversation

@EOT3000

@EOT3000 EOT3000 commented Jun 11, 2023

Copy link
Copy Markdown
Contributor

Adds a way to modify some properties of individual stored entities (bees in beehive), as well as release them individually, without having to release them all.

With requested changes.

@katekerllenevich katekerllenevich left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whitespace stuff is largely just to make the diff smaller and more maintainable for us, nothing against your code style.

Comment thread patches/server/0307-Stored-Bee-API.patch
Comment thread patches/server/0307-Stored-Bee-API.patch Outdated
Comment thread patches/server/0307-Stored-Bee-API.patch Outdated
Comment thread patches/server/0307-Stored-Bee-API.patch Outdated
Comment thread patches/server/0307-Stored-Bee-API.patch Outdated
Comment thread patches/server/0307-Stored-Bee-API.patch Outdated
Comment thread patches/server/0307-Stored-Bee-API.patch Outdated
Comment thread patches/api/0051-Stored-Bee-API.patch Outdated
Comment thread patches/server/0307-Stored-Bee-API.patch Outdated
Comment thread patches/server/0307-Stored-Bee-API.patch Outdated
@EOT3000

EOT3000 commented Jun 12, 2023

Copy link
Copy Markdown
Contributor Author

Done.

@katekerllenevich katekerllenevich requested a review from granny June 14, 2023 23:04
@granny granny changed the base branch from ver/1.20 to ver/1.20.1 June 25, 2023 23:49

@granny granny left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. For future reference make sure to create a new branch specifically for the PR you're creating instead of committing directly to the ver/... branch.

@granny granny merged commit db86b6e into PurpurMC:ver/1.20.1 Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants