Shears can defuse TNT#1372
Merged
Merged
Conversation
Shears can now defuse TNT when right clicked
granny
requested changes
Jul 2, 2023
granny
left a comment
granny
left a comment
Member
There was a problem hiding this comment.
Currently on mobile so i can't look into the implementation, so nitpicking for now until I can take a better look. Patch diffs should touch as little as possible to lower the maintenance burden of each patch.
Contributor
Author
|
Both been reverted. Didn't pick up on this during committing! |
Checks if level is client sided or not, adds permission for defusing TNT (purpur.tnt.defuse), handles damaging item more appropriately and item drop to mimic vanilla behaviour better. Formatted code slightly better incase future implementations are used within the method.
granny
approved these changes
Jul 3, 2023
granny
left a comment
granny
left a comment
Member
There was a problem hiding this comment.
LGTM :)
All that's left is to document the config option and permission in the docs (https://github.com/purpurMC/purpurdocs) and the patch will be merged!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TNT can now be defused when right clicking with shears, nothing more to it than an additional gameplay mechanic.
Option is per-world and a value of 0.00 disables the function. See patch commit for a few more details