Skip to content

Fix bee count payload lag/crash exploit and make it configurable.#1489

Closed
dexuby wants to merge 3 commits into
PurpurMC:ver/1.20.4from
dexuby:ver/1.20.4
Closed

Fix bee count payload lag/crash exploit and make it configurable.#1489
dexuby wants to merge 3 commits into
PurpurMC:ver/1.20.4from
dexuby:ver/1.20.4

Conversation

@dexuby

@dexuby dexuby commented Feb 18, 2024

Copy link
Copy Markdown
Contributor

Just a quick fix. This is generally a questionable feature, nothing about it is documented and it validates nearly nothing. Players can spam custom payload packets targeting locations anywhere in the world causing chunk loads resulting in freezing.

Added config option for bee count payload.

@granny granny left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Merge your patch into the ###-give-bee-counts-in-beehives-to-Purpur-clients.patch patch
  2. PurpurConfig, not PufferfishConfig
  3. Needs to be documented at https://github.com/PurpurMC/PurpurDocs
  4. Set it as false by default. Someone requested this option a while ago and I don't mind it being disabled by default. Will need to double check that the PurpurClient mod doesn't freak out if it's disabled.

@granny granny added the needs-docs A pull request to PurpurDocs is required before merge label Feb 18, 2024
@YouHaveTrouble

Copy link
Copy Markdown
Member

If we're fixing things, let's fix them correctly. This shouldn't work unless player is in the range of the debug targeting range. This would prevent this becoming NoCom 2.0

@dexuby

dexuby commented Feb 18, 2024

Copy link
Copy Markdown
Contributor Author

A range check would be nice but I'm generally not too sure why this feature is necessary and what it's being used for (found nothing in the docs) so I didn't implement one. So this is being used by a Purpur mod to render some extra info?

@YouHaveTrouble

Copy link
Copy Markdown
Member

Yep. it's for PurpurClient feature that displays the bee count in F3 menu

@dexuby

dexuby commented Feb 18, 2024

Copy link
Copy Markdown
Contributor Author

Thanks, implemented a range limit of 16 now, that seems to be the max range when targeting blocks.

@granny granny left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will merge later this afternoon (PST). Thanks for the PR!

@granny granny removed the needs-docs A pull request to PurpurDocs is required before merge label Feb 18, 2024
@granny

granny commented Feb 19, 2024

Copy link
Copy Markdown
Member

GitHub CLI fucked up when I tried pushing to your PR so I've gone ahead and just merged the branch that was unintentionally created. Your changes have been merged.

@granny granny closed this Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants