Fix bee count payload lag/crash exploit and make it configurable.#1489
Fix bee count payload lag/crash exploit and make it configurable.#1489dexuby wants to merge 3 commits into
Conversation
Added config option for bee count payload.
granny
left a comment
There was a problem hiding this comment.
- Merge your patch into the
###-give-bee-counts-in-beehives-to-Purpur-clients.patchpatch PurpurConfig, notPufferfishConfig- Needs to be documented at https://github.com/PurpurMC/PurpurDocs
- Set it as
falseby default. Someone requested this option a while ago and I don't mind it being disabled by default. Will need to double check that the PurpurClient mod doesn't freak out if it's disabled.
|
If we're fixing things, let's fix them correctly. This shouldn't work unless player is in the range of the debug targeting range. This would prevent this becoming NoCom 2.0 |
This reverts commit b61eee9.
|
A range check would be nice but I'm generally not too sure why this feature is necessary and what it's being used for (found nothing in the docs) so I didn't implement one. So this is being used by a Purpur mod to render some extra info? |
|
Yep. it's for PurpurClient feature that displays the bee count in F3 menu |
|
Thanks, implemented a range limit of 16 now, that seems to be the max range when targeting blocks. |
granny
left a comment
There was a problem hiding this comment.
Will merge later this afternoon (PST). Thanks for the PR!
|
GitHub CLI fucked up when I tried pushing to your PR so I've gone ahead and just merged the branch that was unintentionally created. Your changes have been merged. |
Just a quick fix. This is generally a questionable feature, nothing about it is documented and it validates nearly nothing. Players can spam custom payload packets targeting locations anywhere in the world causing chunk loads resulting in freezing.