Skip to content

Fix compilation issues#1509

Merged
granny merged 3 commits into
PurpurMC:ver/1.20.5from
Krakenied:ver/1.20.5
Apr 28, 2024
Merged

Fix compilation issues#1509
granny merged 3 commits into
PurpurMC:ver/1.20.5from
Krakenied:ver/1.20.5

Conversation

@Krakenied

@Krakenied Krakenied commented Apr 28, 2024

Copy link
Copy Markdown
Contributor
  • removed placeables/destroyables setters and getters as there's currently no sensible way of implementing it

Upstream has released updates that appear to apply and compile correctly

Paper Changes:
PaperMC/Paper@1a03cc9 Fix test compilation
PaperMC/Paper@6e31f38 Fix book meta lacking resolved tag from older versions (Fixes #10470)
PaperMC/Paper@37b3891 Fix another missing book meta tag
PaperMC/Paper@c4a1cd1 Fix issue with empty lists in adventure predicates
PaperMC/Paper@9d6e7e3 Don't hard fail on plugin remap error
PaperMC/Paper@4491ac0 respect hard list size limits in ItemMeta
PaperMC/Paper@aed7dca Fix overly strong name validation in player heads
PaperMC/Paper@0f4d328 final missing validation for data components
PaperMC/Paper@52ff3b7 Add itemName components (Resolves #10467) (#10471)
PaperMC/Paper@ba673a3 [ci skip] Feature requests are now in GitHub Discussions (#10606)
PaperMC/Paper@0f3e324 [ci skip] Fix discussion template file name (#10607)
@Krakenied Krakenied marked this pull request as ready for review April 28, 2024 20:00
@Krakenied

Copy link
Copy Markdown
Contributor Author

Somebody more into Purpur needs to take a look at the second half of the issues as I really don't know how to make some features still work after conversion from 1.20.4 to 1.20.5 (due to tags/components)

@granny granny left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the help :)

@granny granny merged commit dc9993f into PurpurMC:ver/1.20.5 Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants