Skip to content

Add Creaking configs#1613

Merged
granny merged 4 commits into
PurpurMC:ver/1.21.3from
Onako2:add-creaking
Nov 26, 2024
Merged

Add Creaking configs#1613
granny merged 4 commits into
PurpurMC:ver/1.21.3from
Onako2:add-creaking

Conversation

@Onako2

@Onako2 Onako2 commented Nov 25, 2024

Copy link
Copy Markdown
Contributor

Checklist:

  • Add Rideables config
  • Add attributes such as scale

creaking_transient doesn't support riding. Even when I tried forcefully putting the player on a creaking_transient the player would desync. Creaking Transient will be removed anyway in 1.21.4.

@Onako2 Onako2 marked this pull request as ready for review November 25, 2024 20:49
Comment thread patches/server/0007-Ridables.patch Outdated
Comment thread patches/server/0007-Ridables.patch Outdated
@Onako2 Onako2 requested a review from granny November 26, 2024 11:24

@granny granny left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :) Will be merged once a PR is made to PurpurDocs with the new options.

@granny granny added the needs-docs A pull request to PurpurDocs is required before merge label Nov 26, 2024
@Onako2

Onako2 commented Nov 26, 2024

Copy link
Copy Markdown
Contributor Author

Ok, I planned anyway to do a PR to docs lol

@granny granny merged commit 06dde9d into PurpurMC:ver/1.21.3 Nov 26, 2024
@granny granny removed the needs-docs A pull request to PurpurDocs is required before merge label Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants