Skip to content

Add configuration setting to re-add End void rings#1656

Merged
granny merged 3 commits into
PurpurMC:ver/1.21.5from
linaTetris:1.21.5-end-voids
May 3, 2025
Merged

Add configuration setting to re-add End void rings#1656
granny merged 3 commits into
PurpurMC:ver/1.21.5from
linaTetris:1.21.5-end-voids

Conversation

@linaTetris

@linaTetris linaTetris commented Apr 22, 2025

Copy link
Copy Markdown
Contributor

For players who want the End void rings to be re-added to Purpur given that Paper has patched it. Players who are interested in building large-scale map art (especially transparent map art) or building large space-based structures in the void will benefit from changing the configuration settings.

This PR adds a simple global setting switch generate-end-void-rings to toggle the rings (default set to false to have the fixed terrain generation).

Requesting backport of this config setting into 1.21.4.

@granny

granny commented Apr 22, 2025

Copy link
Copy Markdown
Member

Haven't looked at the PR yet, but if it gets accepted/merged, a backport will not happen.

@granny granny left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just needs a PR to PurpurDocs to document the option :)

@granny granny added the needs-docs A pull request to PurpurDocs is required before merge label Apr 29, 2025
@Onako2

Onako2 commented May 2, 2025

Copy link
Copy Markdown
Contributor

LGTM! Just needs a PR to PurpurDocs to document the option :)

If no one wants to do it, I can do it

@granny granny removed the needs-docs A pull request to PurpurDocs is required before merge label May 3, 2025
@granny granny merged commit 93011bc into PurpurMC:ver/1.21.5 May 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants