Add configuration setting to re-add End void rings#1656
Merged
Conversation
Member
|
Haven't looked at the PR yet, but if it gets accepted/merged, a backport will not happen. |
granny
approved these changes
Apr 29, 2025
granny
left a comment
Member
There was a problem hiding this comment.
LGTM! Just needs a PR to PurpurDocs to document the option :)
Contributor
If no one wants to do it, I can do it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For players who want the End void rings to be re-added to Purpur given that Paper has patched it. Players who are interested in building large-scale map art (especially transparent map art) or building large space-based structures in the void will benefit from changing the configuration settings.
This PR adds a simple global setting switch
generate-end-void-ringsto toggle the rings (default set tofalseto have the fixed terrain generation).Requesting backport of this config setting into 1.21.4.