Make beacons not apply effects when covered or base destroyed while using "allow-effects-with-tinted-glass"#1746
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1741 which reported unexpected beacon behavior while using tinted glass and "allow-effects-with-tinted-glass".
The problem with the base not updating was that with tinted glass being an opaque block it would still cause
blockEntity.beamSectionsto be empty causing the below code to not check if the base of the beacon has changed.The problem with the opaque block check failing above tinted glass was that
isTintedGlassserved as an override to the condition before applying the effects. To fix it I just setisTintedGlassto false if the block is opaque and not tinted glass.