fix configurable daylight cycle not working#1788
Merged
Merged
Conversation
7372415 to
13e2b89
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add back the configurable daylight cycle feature by updating the clock instances on every tick.
incrementTicksis the config value that gets multiplied by the clock instancerate(So that our custom daylight cycle will also respect the rate if provided using/timeetc).Clock instance's
rategoes back to the original value so it won't overflow if it gets multiplied again and again.Sync with the client's time using
broadcastUpdates()Note:
time.affects-all-worldsmeaning if this value istrue, the daylight cycle will use the overworld ones (The cycle will be global than per-world, since this is easier to work with and maintain)I tested various values, along with the time commands and rate, it works as intended.
Fixes #1776