Config for health to impact Creeper explosion radius#304
Merged
Conversation
encode42
force-pushed
the
feature/creeper-health-explosion
branch
from
c609f01 to
dc66f46
Compare
katekerllenevich
approved these changes
Apr 30, 2021
katekerllenevich
left a comment
katekerllenevich
left a comment
Member
There was a problem hiding this comment.
lgtm, a cool feature would be to invert this and make the explosions bigger with less health.
Member
Yeah, I suggested making config option a number value that multiplies explosion force and if it's negative it reverses the health scaling calculation |
Member
|
we could use the js expression evaluation to make the full equation customizable |
BillyGalbreath
force-pushed
the
feature/creeper-health-explosion
branch
from
dc66f46 to
f82f22b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows for a Creeper's explosion to be affected by its health value.
This should scale with any custom explosion radius or max health set.
Equation: Creeper's explosion radius multiplied by percentage of max health
(health / max health) * (explosion radius * charged multiplier)Update for those wondering why this hasn't been merged yet: We're currently making sure the JavaScript engine Purpur integrates is functioning correctly, then this PR will change to allow for the equation to be customized by the user.
Explosion radius with feature disabled:
Explosion radius at full health:
Explosion radius at half health:
