Redirect System.out calls to plugin loggers#429
Merged
Conversation
BillyGalbreath
force-pushed
the
SysoutCatcher
branch
2 times, most recently
from
85a553f to
88d23e0
Compare
katekerllenevich
approved these changes
Jun 29, 2021
YouHaveTrouble
approved these changes
Jun 29, 2021
YouHaveTrouble
left a comment
YouHaveTrouble
left a comment
Member
There was a problem hiding this comment.
Don't see any way to improve it further tbh, lgtm and seems to be correct
BillyGalbreath
force-pushed
the
SysoutCatcher
branch
from
88d23e0 to
f7d42d5
Compare
granny
approved these changes
Jul 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening this as a PR in case anyone has ideas for improvement.
We've been wanting to add this for a long time now, and this is basically a direct copy of Vicarious' plugin logic that works for Java 8+. I heard there was an easier/better way with the newer Java versions.