Skip to content

Fix and add config spawner silktouch #448

Closed
Euphillya wants to merge 3 commits into
PurpurMC:ver/1.17from
ExcaliaSI:spawner-fix-and-level-minimal
Closed

Fix and add config spawner silktouch #448
Euphillya wants to merge 3 commits into
PurpurMC:ver/1.17from
ExcaliaSI:spawner-fix-and-level-minimal

Conversation

@Euphillya

@Euphillya Euphillya commented Jun 29, 2021

Copy link
Copy Markdown
Contributor

Dont drop xp when spawner is destroy with silktouch and add minimal level require enchant for drop spawner

@Euphillya Euphillya changed the title Dont drop xp when spawner is destroy with silktouch and add minimal level require enchant for drop spawner Fix and add config spawner Jun 29, 2021
@Euphillya Euphillya changed the title Fix and add config spawner Fix and add config spawner silktouch Jun 29, 2021

@granny granny left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requires a rebase.

While looking at this I'm a bit confused on the point of minimumSilkTouchSpawnerRequire. Silk Touch only has one level; why should this be an option?

@YouHaveTrouble

Copy link
Copy Markdown
Member

While looking at this I'm a bit confused on the point of minimumSilkTouchSpawnerRequire. Silk Touch only has one level; why should this be an option?

Technically there are multiple silk touch levels, while only the first one is normally available I've seen plugins utilising the additional ones

@Euphillya

Copy link
Copy Markdown
Contributor Author

requires a rebase.

While looking at this I'm a bit confused on the point of minimumSilkTouchSpawnerRequire. Silk Touch only has one level; why should this be an option?

Servers like mine use a level 2 silktouch in order to retrieve the spawner as it can be considered a special item. Plugins do it, it would be a shame not to integrate it while the goal of this patch is not to use a plugin that tampers with the NMS to do what it does.

@granny

granny commented Jul 1, 2021

Copy link
Copy Markdown
Member

requires a rebase.
While looking at this I'm a bit confused on the point of minimumSilkTouchSpawnerRequire. Silk Touch only has one level; why should this be an option?

Servers like mine use a level 2 silktouch in order to retrieve the spawner as it can be considered a special item. Plugins do it, it would be a shame not to integrate it while the goal of this patch is not to use a plugin that tampers with the NMS to do what it does.

Gotcha. sounds good with me

@Euphillya

Copy link
Copy Markdown
Contributor Author

Rebase to : #454

@Euphillya Euphillya closed this Jul 1, 2021
@Euphillya Euphillya deleted the spawner-fix-and-level-minimal branch July 1, 2021 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants