Skip to content

Extended OfflinePlayer API#605

Merged
BillyGalbreath merged 6 commits into
PurpurMC:ver/1.17.1from
YouHaveTrouble:ver/1.17.1
Aug 22, 2021
Merged

Extended OfflinePlayer API#605
BillyGalbreath merged 6 commits into
PurpurMC:ver/1.17.1from
YouHaveTrouble:ver/1.17.1

Conversation

@YouHaveTrouble

@YouHaveTrouble YouHaveTrouble commented Aug 22, 2021

Copy link
Copy Markdown
Member
  • Added some methods to OfflinePlayer class.
  • Added convienience method for saving player file after modifications to the nbt data
  • All methods fall back to getPlayer methods if the player is online

edit: apparently build failed, going to bed, gonna fix when I wake up
edit2: builds and runs for me locally

Comment thread patches/server/0252-Extended-OfflinePlayer-API.patch

@katekerllenevich katekerllenevich left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, waiting for billy.

@YouHaveTrouble

Copy link
Copy Markdown
Member Author

There's a small discrepency between the javadoc and impl, fixing in next commit

@BillyGalbreath BillyGalbreath merged commit 710f21b into PurpurMC:ver/1.17.1 Aug 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants