Add water damage to all mobs#661
Closed
sph432 wants to merge 2 commits into
Closed
Conversation
BillyGalbreath
suggested changes
Sep 16, 2021
Contributor
|
I like it. Maybe we should extend this to all mobs? |
Member
Yes. Also, shouldn't it be in this patch? |
Member
merging with the mentioned patch would be preferred |
Contributor
Author
|
Will change that patch then, I did notice the patch, but did not know about the etiquette of changing another's patch so better be safe, I submitted another. |
Contributor
Author
|
extended config options to all mobs |
sph432
changed the title
granny
requested changes
Sep 29, 2021
granny
left a comment
granny
left a comment
Member
There was a problem hiding this comment.
the naming of some config options does not match
mobs.caveSpider.takes-damage-from-water
should be
mobs.cave_spider.takes-damage-from-water
etc.
also requires a rebase
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.