Fix attribute spam for bats#744
Closed
Camotoy wants to merge 1 commit into
Closed
Conversation
Addresses PurpurMC#728 Since the client doesn't need these attributes, indicate that they shouldn't be sent. This doesn't appear to impact the bat from being ridable.
encode42
reviewed
Nov 11, 2021
encode42
left a comment
encode42
left a comment
Contributor
There was a problem hiding this comment.
LGTM, needs a rebase though
katekerllenevich
approved these changes
Nov 11, 2021
katekerllenevich
left a comment
katekerllenevich
left a comment
Member
There was a problem hiding this comment.
LGTM, I would like a review from @BillyGalbreath
Contributor
|
Re-open this on the 1.18.1 branch, then it is ready to merge |
Contributor
Author
|
Someone else is free to do that; I'm not sure if I'll get around to it anytime soon. |
encode42
added a commit
that referenced
this pull request
Dec 12, 2021
Co-authored-by: Camotoy <20743703+Camotoy@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #728
Since the client doesn't need these attributes, indicate that they shouldn't be sent. This doesn't appear to impact the bat from being rideable.
Feel free to contact me on Discord! Camotoy#5533