Config to prevent horses from standing when hurt#957
Merged
katekerllenevich merged 3 commits intoMay 9, 2022
Merged
Conversation
encode42
suggested changes
Apr 14, 2022
encode42
approved these changes
Apr 29, 2022
encode42
left a comment
encode42
left a comment
Contributor
There was a problem hiding this comment.
LGTM, just needs additional testing and a potential rebase
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a config option to toggle horses halting and standing on their hind legs when their hurt sound plays.
This behaviour can be undesirable to servers who wish to improve mounted combat. There is currently no way to prevent this behaviour through the API.
Cactus and sweet berry bush damage will still cause the horse to rear. It's not clear to me why - input/changes are appreciated. Otherwise everything appears to work as intended.