You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As I understand it, @see attributes should really only reference one function name. In the cases where both wp_get_attachment_sizes() and wp_calculate_image_sizes() are referenced, I would opt for the function being used, which is generally wp_get_attachment_sizes().
In the phpDoc manual I read "...unlimited number of values separated by commas". Nevertheless, I agree that just referring to wp_get_attachment_image_sizes() is sufficient. There we refer to `wp_calculate_image_sizes(). The same goes for the srcset functions.
I also noticed that we should wrap the function names in quotes or backticks.
Will update this PR.
Update: Actually we don't use @see in wp_get_attachment_image_sizes() to refer to wp_calculate_image_sizes() but I think it's fine to just refer to wp_get_attachment_image_sizes()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.