feat: action sheet bottom blank space

[OtavioStasiak]

Proposed changes

Removes the extra blank space at the bottom of action-sheet content. These views
were adding marginBottom: insets.bottom on top of the safe-area inset the action
sheet already applies, producing a double gap:

• DirectoryView/Options, MediaAutoDownloadView/ListPicker, RoomsListView/ServersList
  — drop the redundant marginBottom (and the now-unused useSafeAreaInsets).
• UserNotificationPreferencesView/ListPicker — switch marginBottom → paddingBottom
  so the inset sits inside the content.

Issue(s)

https://rocketchat.atlassian.net/browse/NATIVE-1254

How to test or reproduce

1. Servers list — Rooms list header → tap the server name/avatar (top-left) to open
   the servers list sheet.
2. Directory options — Search/Directory view → tap the filter/options control.
3. Media auto-download — Settings → Media auto-download → tap one of the options
   (e.g. Images) to open its picker sheet.
4. Notification preferences — Room → Notification Preferences → tap an option (e.g.
   Alert) to open its picker sheet.

Screenshots

ServersList (Before)	ServersList (After)

ServersList Landscape (Before)	ServersList Landscape (After)

DirectoryOptions (Before)	DirectoryOptions (After)

MediaAutoDownload (Before)	MediaAutoDownload (After)

NotificationPreferences (Before)	NotificationPreferences (After)

Types of changes

• Bugfix (non-breaking change which fixes an issue)
• Improvement (non-breaking change which improves a current function)
• New feature (non-breaking change which adds functionality)
• Documentation update (if none of the other choices apply)

Checklist

• I have read the CONTRIBUTING doc
• I have signed the CLA
• Lint and unit tests pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works (if applicable)
• I have added necessary documentation (if applicable)
• Any dependent changes have been merged and published in downstream modules

Further comments

Summary by CodeRabbit

• Refactor

  • Improved safe-area handling for bottom spacing in action sheets and option pickers across Directory options, Media auto-download, server list, and notification preferences (removing bottom inset marginBottom and adjusting how bottom spacing is applied for consistent layout).

• Tests

  • Added/updated Jest tests to ensure action sheet content doesn’t double-apply the bottom safe-area inset.
  • Added a Maestro regression test (“Action Sheet Safe Area”) covering both Workspaces and Directory filter action sheets.

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

Walkthrough

Three view components (DirectoryView/Options, MediaAutoDownloadView/ListPicker) remove useSafeAreaInsets entirely and drop marginBottom: insets.bottom. RoomsListView/ServersList also removes safe-area insets but now uses useWindowDimensions with a new layout helper getServersListMaxHeight() to compute dynamic list heights. UserNotificationPreferencesView/ListPicker retains insets but changes marginBottom to paddingBottom. Unit tests and a Maestro E2E test validate the safe-area behavior across all components.

Changes

Safe-area inset bottom spacing cleanup and validation

Layer / File(s)	Summary
Remove useSafeAreaInsets bottom margin from DirectoryView and MediaAutoDownloadView with unit tests app/views/DirectoryView/Options.tsx, app/views/DirectoryView/Options.test.tsx, app/views/MediaAutoDownloadView/ListPicker.tsx, app/views/MediaAutoDownloadView/ListPicker.test.tsx	DirectoryView/Options and MediaAutoDownloadView/ListPicker each remove the useSafeAreaInsets import and hook call, and drop marginBottom: insets.bottom from the container style. Unit tests verify that marginBottom is not set when the mocked safe-area inset is non-zero.
New layout helper module for ServersList height calculation app/views/RoomsListView/components/serversListLayout.ts, app/views/RoomsListView/components/serversListLayout.test.ts	New serversListLayout.ts module exports row sizing constants and getServersListMaxHeight(windowHeight) function that computes a clamped list height based on fixed chrome and action-sheet maximum height fraction. Tests verify portrait/landscape behavior, shrink-to-fit logic, and minimum height guarantees.
ServersList refactoring to use window dimensions and new layout helper app/views/RoomsListView/components/ServersList.tsx	RoomsListView/ServersList replaces useSafeAreaInsets with useWindowDimensions, removes safe-area-based marginBottom from the header, and switches FlatList maxHeight from a static calculation to dynamic getServersListMaxHeight(windowHeight) for responsive list sizing.
Switch marginBottom to paddingBottom in UserNotificationPreferencesView/ListPicker with unit test app/views/UserNotificationPreferencesView/ListPicker.tsx, app/views/UserNotificationPreferencesView/ListPicker.test.tsx	The getOptions container <View> changes its safe-area bottom handling from marginBottom: insets.bottom to paddingBottom: insets.bottom. Unit test asserts marginBottom is not applied.
Maestro E2E test for action sheet safe-area behavior .maestro/tests/assorted/action-sheet-safe-area.yaml	Test validates action sheet bottom spacing across Workspaces (ServersList) and Directory filter (DirectoryOptions) action sheets, ensuring bottom-row elements remain visible and accessible after the safe-area spacing changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~13 minutes

Suggested reviewers

• diegolmello

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'feat: action sheet bottom blank space' directly describes the main change: fixing extra blank space at the bottom of action sheets, which is the core issue addressed throughout the PR.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)

• NATIVE-1254: Request failed with status code 401

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

Android Build Available

Rocket.Chat 4.74.0.109163

Internal App Sharing: https://play.google.com/apps/test/RQQ8k09hlnQ/ahAO29uNQKaDNy9H8ZFrjQHcMPu_Hn2DnLQxnoBmCLTxlheve21yC6JopIwQrq-Jm4NxBCfs7d3yJHFPovjzuRTJ-8