Skip to content

fix: video column type compatible#1683

Merged
SAKURA-CAT merged 1 commit into
mainfrom
fix/video-type-compatible
Jun 11, 2026
Merged

fix: video column type compatible#1683
SAKURA-CAT merged 1 commit into
mainfrom
fix/video-type-compatible

Conversation

@Nexisato

@Nexisato Nexisato commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Description

  • Revert Video type to column_image for compatible field

Test Code

import swanlab

if __name__ == "__main__":
    swanlab.init(project="demo-charts-test", name="video-chart-test")

    swanlab.log({"video": swanlab.Video("./demo.gif", caption="test caption")})

    swanlab.finish()

📊 Demo Runs:

  • Image Type: nexisato/demo-charts-test/runs/c7e7ozl2/chart
  • Video Type: nexisato/demo-charts-test/runs/ls17l20a/chart

TODO: docs (url ref)

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request temporarily changes the column type for video data from ColumnType.COLUMN_TYPE_VIDEO to ColumnType.COLUMN_TYPE_IMAGE in both the video transform implementation and its corresponding unit test, adding TODO comments to revert this change once the server supports the VIDEO column type. I have no feedback to provide as there are no review comments.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@Nexisato Nexisato self-assigned this Jun 11, 2026
@Nexisato Nexisato added the 🐛 bug Something isn't working label Jun 11, 2026
@Nexisato Nexisato requested a review from SAKURA-CAT June 11, 2026 09:09
@SAKURA-CAT SAKURA-CAT merged commit 84a585d into main Jun 11, 2026
19 checks passed
@SAKURA-CAT SAKURA-CAT deleted the fix/video-type-compatible branch June 11, 2026 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants