Display warnings for deprecated schemata and properties#1182
Merged
Conversation
pudo
approved these changes
Jul 24, 2023
pudo
left a comment
Contributor
There was a problem hiding this comment.
Looks amazing and the code changes are minimal! :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This shows small warning indicators in schemata and properties tables (and a popup with an explanation on mouseover), and a warning message below the header on schema pages.
Schemata table:
Schema details page:
Properties table:
(I marked
Thing:addressas deprecated only for demonstration because we currently do not have any deprecated properties.)