Adopt prefixdate library for parsing dates#441
Conversation
Rosencrantz
left a comment
There was a problem hiding this comment.
Alright, just so I understand what you're proposing here. You're looking to remove the big, ugly Regex with a library that does the same thing, and this is why most of this PR is removing code?
|
Haha, I guess the point is that the library uses one fat regex to do a lot of the stuff that's happening in individual steps here (like that weird One thing that's a bit "complicated" is that |
|
OK, the time issue is fixed. |
This would adopt the
prefixdatelibrary, which makes some of the logic of the existing date parsing more explicit. When applied, this should:a) Speed up date processing, both for format-string based parsing and for normal validation.
b) Truncate prefixes for minutes and seconds from times when they are
00.c) Fix an apparent issue with time zone conversion in
to_datetime.