Skip to content

fix(sandbox): Windows WFP status access denied check#304

Open
hsm-lv wants to merge 1 commit into
anthropic-experimental:mainfrom
hsm-lv:codex/windows-wfp-status-access-denied
Open

fix(sandbox): Windows WFP status access denied check#304
hsm-lv wants to merge 1 commit into
anthropic-experimental:mainfrom
hsm-lv:codex/windows-wfp-status-access-denied

Conversation

@hsm-lv

@hsm-lv hsm-lv commented Jun 12, 2026

Copy link
Copy Markdown

Summary

  • Treat access-denied failures from srt-win wfp status as a dependency warning instead of a hard error.
  • Add a focused helper for detecting WFP status access-denied messages and unit coverage for the common Windows forms.

Why

checkWindowsDependencies already verifies the Windows group state before checking WFP. On systems where wfp status cannot be queried without administrator rights, the dependency check currently reports a fatal srt-win wfp status failed error even though this status probe is only used to verify the installed filter set.

Root Cause

The WFP status catch path did not classify Windows access-denied status errors separately, so non-admin WFP status verification failures were handled the same as real status command failures.

Testing

  • npm run typecheck
  • npm run lint:check
  • npm run build
  • bun test test/sandbox/winsrt.test.ts

@hsm-lv hsm-lv changed the title [codex] fix Windows WFP status access denied check fix(sandbox): Windows WFP status access denied check Jun 12, 2026
@hsm-lv hsm-lv marked this pull request as ready for review June 12, 2026 11:27
@LLukas22

Copy link
Copy Markdown

I'm also encountering this error on my company computer. I don't think elevation should be required to use srt-win this PR addresses that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants