fix(sandbox): Windows WFP status access denied check#304
Open
hsm-lv wants to merge 1 commit into
Open
Conversation
CheshireJCat
approved these changes
Jun 12, 2026
|
I'm also encountering this error on my company computer. I don't think elevation should be required to use srt-win this PR addresses that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
srt-win wfp statusas a dependency warning instead of a hard error.Why
checkWindowsDependenciesalready verifies the Windows group state before checking WFP. On systems wherewfp statuscannot be queried without administrator rights, the dependency check currently reports a fatalsrt-win wfp status failederror even though this status probe is only used to verify the installed filter set.Root Cause
The WFP status catch path did not classify Windows access-denied status errors separately, so non-admin WFP status verification failures were handled the same as real status command failures.
Testing
npm run typechecknpm run lint:checknpm run buildbun test test/sandbox/winsrt.test.ts