Skip to content

Preserve outgoing suggestion comment bodies#1372

Draft
tarunag10 wants to merge 1 commit into
anthropics:mainfrom
tarunag10:codex/preserve-inline-suggestion-body
Draft

Preserve outgoing suggestion comment bodies#1372
tarunag10 wants to merge 1 commit into
anthropics:mainfrom
tarunag10:codex/preserve-inline-suggestion-body

Conversation

@tarunag10

Copy link
Copy Markdown

Summary

  • add a narrower sanitizer for outgoing GitHub comments that redacts tokens without stripping visible Markdown or HTML attributes
  • use it for inline review comments and Claude comment updates
  • add regression coverage for suggestion blocks containing quoted attributes and apostrophes

Fixes #1366.

Validation

  • npx tsc --noEmit
  • npx prettier --check src/github/utils/sanitizer.ts src/mcp/github-comment-server.ts src/mcp/github-inline-comment-server.ts test/sanitizer.test.ts

Note

I could not run bun test test/sanitizer.test.ts in this environment because bun is not installed. I installed npm dependencies with --legacy-peer-deps --no-package-lock --ignore-scripts only to run TypeScript and Prettier checks locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

github_inline_comment corrupts suggestion block body when the suggested line has embedded quotes

1 participant