Add draft threat model + AGENTS.md and link from SECURITY.md for security-model discoverability#457
Open
potiuk wants to merge 1 commit into
Open
Conversation
…ecurity-model discoverability Adds a draft (v0) threat model for the Fediz WS-Federation/SAML-SSO IdP + RP plugins, plus an AGENTS.md, and links the model from the existing SECURITY.md so an automated scan agent can discover it via AGENTS.md -> SECURITY.md -> THREAT_MODEL.md. The model is a proposal for the PMC to review; most claims are (inferred) and route to open questions in its section 14. Generated-by: Claude Code (Claude Opus 4.8)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a draft proposal for the CXF PMC to review — please correct, reject, or discuss as needed. Nothing here is a requirement; the maintainers are the decision-makers.
Companion to the
apache/cxfumbrella PR — Fediz's WS-Federation / SAML-SSO trust surface is distinct, so it gets its own model. This PR addsTHREAT_MODEL.md+AGENTS.mdand a Threat Model section in the existingSECURITY.md, wiringAGENTS.md -> SECURITY.md -> THREAT_MODEL.md.The model's pivot: in SSO the security-relevant work is token validation at the RP and issuance at the IdP, around a token that travels through the untrusted browser. Draft-first, mostly inferred (~12 documented / 0 maintainer / ~46 inferred); every
*(inferred)*claim routes to a numbered §14 question.The wave-1 rulings are the SSO crux:
wtrealm,Conditions(timestamps + skew), and a replay cache enforced by default?Also flagged:
wreplyreply-URL allow-listing (open redirect / token forwarding) and XXE/DoS on token parse (inherited from CXF/WSS4J).Context: the ASF Security team is preparing the project for an automated agentic security scan we're piloting. Drafted via the threat-model-producer rubric. If you'd rather author it yourselves, close this PR and we'll regroup.