Skip to content

Claude/review dotiles project 01 tm9 z bvwmp4n yt9pozbx vsl#87

Merged
blackwell-systems merged 3 commits into
mainfrom
claude/review-dotiles-project-01Tm9ZBvwmp4nYt9pozbxVSL
Nov 29, 2025
Merged

Claude/review dotiles project 01 tm9 z bvwmp4n yt9pozbx vsl#87
blackwell-systems merged 3 commits into
mainfrom
claude/review-dotiles-project-01Tm9ZBvwmp4nYt9pozbxVSL

Conversation

@blackwell-systems

Copy link
Copy Markdown
Owner

Pull Request

Description

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes)
  • Performance improvement
  • Test addition/improvement

Motivation and Context

Fixes # (issue)

Changes Made

Testing

How Has This Been Tested?

Test Configuration:

  • Platform:
  • OS Version:
  • Shell:

Test Steps:

Test Checklist

  • Tested on macOS
  • Tested on Linux/Lima
  • Ran dotfiles doctor successfully
  • Bootstrap script completes without errors
  • Scripts are idempotent (can run multiple times safely)
  • Pre-commit hooks pass
  • No secrets or personal information in commits

Screenshots (if applicable)

Before:

After:

Documentation

  • Updated README.md (if needed)
  • Updated CHANGELOG.md
  • Added/updated code comments
  • Updated vault/README.md (if vault changes)
  • No documentation changes needed

Breaking Changes

  • No breaking changes
  • Yes, breaking changes (describe below)

Breaking Changes Description:

Dependencies

  • No new dependencies
  • Added to Brewfile:
  • Updated dependency versions:

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings or errors
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published
  • I have read the CONTRIBUTING guide
  • All commits follow the commit message conventions

Additional Notes

Reviewer Notes


For Maintainers:

  • Code review completed
  • Tests pass in CI/CD
  • Documentation is adequate
  • Ready to merge

Claude added 3 commits November 29, 2025 16:59
High Priority Fixes:
- Add MINGW/MSYS/Cygwin detection to install.sh (native Windows support)
- Create bootstrap-windows.sh for Git Bash/MSYS2 environments
- Add Windows shell handling to 00-init.zsh (paths, clipboard, aliases)
- Rename sync-to-bitwarden.sh to sync-to-vault.sh (backend-agnostic)
- Update all help text from "Bitwarden" to generic "vault"
- Fix doctor line count: 573 → 446 lines

Documentation Consistency:
- Update README.md and docs/README.md with Windows platform support
- Update vault references to use 'dotfiles vault sync' command
- Update all script references and architecture docs
- Add Windows (Git Bash/MSYS2) to platform support tables
- Update multi-vault terminology throughout docs

Files changed:
- install.sh: Add MINGW/MSYS/Cygwin case
- bootstrap/bootstrap-windows.sh: New Windows bootstrap script
- zsh/zsh.d/00-init.zsh: Windows shell environment
- zsh/zsh.d/40-aliases.zsh: Generic vault help text
- vault/sync-to-vault.sh: Renamed from sync-to-bitwarden.sh
- Multiple docs: Consistent vault terminology
Resolved conflicts by keeping our multi-vault and Windows support updates.
Merged additional changes from main:
- CHANGELOG.md updates
- SECURITY.md updates
- claude/commands/vault.md updates
- docs updates (NOTES, ROADMAP, troubleshooting)
- Add on_session_start hook to check git sync status automatically
- Add comprehensive Git Safety Rules section to CLAUDE.md
- Rules cover: sync before working, no force push, check before commit,
  one session at a time
- Hook runs `git fetch && git status --porcelain=v2 --branch` to detect
  divergence before any work begins
- Bump version to 1.8.0
@blackwell-systems blackwell-systems merged commit d234cbb into main Nov 29, 2025
20 of 22 checks passed
@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

blackwell-systems added a commit that referenced this pull request Dec 7, 2025
* feat: Add native Windows support and standardize vault terminology

High Priority Fixes:
- Add MINGW/MSYS/Cygwin detection to install.sh (native Windows support)
- Create bootstrap-windows.sh for Git Bash/MSYS2 environments
- Add Windows shell handling to 00-init.zsh (paths, clipboard, aliases)
- Rename sync-to-bitwarden.sh to sync-to-vault.sh (backend-agnostic)
- Update all help text from "Bitwarden" to generic "vault"
- Fix doctor line count: 573 → 446 lines

Documentation Consistency:
- Update README.md and docs/README.md with Windows platform support
- Update vault references to use 'dotfiles vault sync' command
- Update all script references and architecture docs
- Add Windows (Git Bash/MSYS2) to platform support tables
- Update multi-vault terminology throughout docs

Files changed:
- install.sh: Add MINGW/MSYS/Cygwin case
- bootstrap/bootstrap-windows.sh: New Windows bootstrap script
- zsh/zsh.d/00-init.zsh: Windows shell environment
- zsh/zsh.d/40-aliases.zsh: Generic vault help text
- vault/sync-to-vault.sh: Renamed from sync-to-bitwarden.sh
- Multiple docs: Consistent vault terminology

* feat: Add git safety rules and session start hook

- Add on_session_start hook to check git sync status automatically
- Add comprehensive Git Safety Rules section to CLAUDE.md
- Rules cover: sync before working, no force push, check before commit,
  one session at a time
- Hook runs `git fetch && git status --porcelain=v2 --branch` to detect
  divergence before any work begins
- Bump version to 1.8.0

---------

Co-authored-by: Claude <noreply@anthropic.com>
blackwell-systems added a commit that referenced this pull request Apr 15, 2026
* feat: Add native Windows support and standardize vault terminology

High Priority Fixes:
- Add MINGW/MSYS/Cygwin detection to install.sh (native Windows support)
- Create bootstrap-windows.sh for Git Bash/MSYS2 environments
- Add Windows shell handling to 00-init.zsh (paths, clipboard, aliases)
- Rename sync-to-bitwarden.sh to sync-to-vault.sh (backend-agnostic)
- Update all help text from "Bitwarden" to generic "vault"
- Fix doctor line count: 573 → 446 lines

Documentation Consistency:
- Update README.md and docs/README.md with Windows platform support
- Update vault references to use 'dotfiles vault sync' command
- Update all script references and architecture docs
- Add Windows (Git Bash/MSYS2) to platform support tables
- Update multi-vault terminology throughout docs

Files changed:
- install.sh: Add MINGW/MSYS/Cygwin case
- bootstrap/bootstrap-windows.sh: New Windows bootstrap script
- zsh/zsh.d/00-init.zsh: Windows shell environment
- zsh/zsh.d/40-aliases.zsh: Generic vault help text
- vault/sync-to-vault.sh: Renamed from sync-to-bitwarden.sh
- Multiple docs: Consistent vault terminology

* feat: Add git safety rules and session start hook

- Add on_session_start hook to check git sync status automatically
- Add comprehensive Git Safety Rules section to CLAUDE.md
- Rules cover: sync before working, no force push, check before commit,
  one session at a time
- Hook runs `git fetch && git status --porcelain=v2 --branch` to detect
  divergence before any work begins
- Bump version to 1.8.0

---------

Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants