download: Improve progress bar

The current progress information for downloads is a bit too verbose:

Downloading 1 files...
Downloading /home/teuf/.crc/cache/crc_libvirt_4.9.0.crcbundle 505MB / 2GB (17%) - 10.07MB/s ETA: 4m12s

It is also inconsistent with the progress information used for bundle
extraction. This commit switches the download code to use
github.com/cheggaaa/pb/v3 for progress, which is the same module as the
one used by the extract package.

Author: cfergeau

pkg/download/download.go

@@ -1,50 +1,69 @@
 package download
 
 import (
-	"context"
 	"crypto/sha256"
 	"encoding/hex"
 	"net/http"
 	"os"
+	"time"
 
 	"github.com/code-ready/crc/pkg/crc/logging"
 	"github.com/code-ready/crc/pkg/crc/network"
 
 	"github.com/cavaliercoder/grab"
-	"github.com/cavaliercoder/grab/grabui"
+	"github.com/cheggaaa/pb/v3"
 	"github.com/pkg/errors"
 )
 
+func doRequest(client *grab.Client, req *grab.Request) (string, error) {
+	resp := client.Do(req)
+
+	t := time.NewTicker(500 * time.Millisecond)
+	defer t.Stop()
+	bar := pb.Start64(resp.Size())
+	bar.Set(pb.Bytes, true)
+	defer bar.Finish()
+
+loop:
+	for {
+		select {
+		case <-t.C:
+			bar.SetCurrent(resp.BytesComplete())
+		case <-resp.Done:
+			break loop
+		}
+	}
+
+	return resp.Filename, resp.Err()
+}
+
 // Download function takes sha256sum as hex decoded byte
 // something like hex.DecodeString("33daf4c03f86120fdfdc66bddf6bfff4661c7ca11c5d")
 func Download(uri, destination string, mode os.FileMode, sha256sum []byte) (string, error) {
 	logging.Debugf("Downloading %s to %s", uri, destination)
 
 	client := grab.NewClient()
 	client.HTTPClient = &http.Client{Transport: network.HTTPTransport()}
-	consoleClient := grabui.NewConsoleClient(client)
 	req, err := grab.NewRequest(destination, uri)
 	if err != nil {
-		return "", errors.Wrapf(err, "unable to get response from %s", uri)
+		return "", errors.Wrapf(err, "unable to get request from %s", uri)
 	}
 	if sha256sum != nil {
 		req.SetChecksum(sha256.New(), sha256sum, true)
 	}
 
-	respCh := consoleClient.Do(context.Background(), 3, req)
-	resp := <-respCh
-
-	if resp.Err() != nil {
-		return "", resp.Err()
+	filename, err := doRequest(client, req)
+	if err != nil {
+		return "", err
 	}
 
-	if err := os.Chmod(resp.Filename, mode); err != nil {
-		_ = os.Remove(resp.Filename)
+	if err := os.Chmod(filename, mode); err != nil {
+		_ = os.Remove(filename)
 		return "", err
 	}
 
-	logging.Debugf("Download saved to %v", resp.Filename)
-	return resp.Filename, nil
+	logging.Debugf("Download saved to %v", filename)
+	return filename, nil
 }
 
 type RemoteFile struct {

vendor/github.com/cavaliercoder/grab/grabui/console_client.go

@@ -55,7 +55,6 @@ github.com/asaskevich/govalidator
 ## explicit
 github.com/cavaliercoder/grab
 github.com/cavaliercoder/grab/bps
-github.com/cavaliercoder/grab/grabui
 # github.com/cheggaaa/pb/v3 v3.0.8
 ## explicit
 github.com/cheggaaa/pb/v3