This repository was archived by the owner on Dec 4, 2018. It is now read-only.
Fix the totally weird way tgtd was handled#231
Merged
Conversation
|
I'm not sure thats a good idea.. our init script does do weird stuff on a restart. |
Member
Author
|
@dirkmueller: afaik, there should be no real change compared to what we are doing today. Except that the code should be less confusing. Or am I missing something? |
|
👍 |
|
@vuntz from my perspective you're inverting the platform check condition from unless to if.. I don't think thats a good idea. |
Always start it, instead of relying on a notification to restart it. Properly declare how to restart it, instead of doing that in a bash command.
Member
Author
|
@dirkmueller good catch. Fixed (but still untested) |
|
+1 |
|
@vuntz I think that this can be merged 👍 |
Member
|
@vuntz Is this PR ready to merge? The title is a little bit unclear due to the WIP. |
Member
Author
|
@rsalevsky sorry, I never actually tested it, hence the title. I can test it in my next deployment, though. |
vuntz
changed the title
Member
Author
|
Seems to work fine, so let's try it in master. |
vuntz
added a commit
that referenced
this pull request
May 13, 2015
Fix the totally weird way tgtd was handled
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This all came from the fact that tgtd wasn't running on a controller, because it was stopped and chef never restarts it.