Skip to content

Fix connection leak of session with dropped keyspace #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ikehara wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix connection leak of session with dropped keyspace #130

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c73f23
modify connect() method of connPool to fix connection leak
ikehara Jun 29, 2024
abdbcfd
modify connect method again to avoid returning values
ikehara Jul 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
modify connect() method of connPool to fix connection leak
  • Loading branch information
@ikehara
ikehara committed Jun 29, 2024
commit 7c73f23033187bf357fa03db4e4719ca84b94e9f
6 changes: 3 additions & 3 deletions proxycore/connpool.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,17 +153,17 @@ func (p *connPool) connect() (conn *ClientConn, err error) {
if errors.Is(err, context.DeadlineExceeded) {
return nil, fmt.Errorf("handshake took longer than %s to complete", p.config.ConnectTimeout)
}
return nil, err
return conn, err
}
if version != p.config.Version {
p.logger.Error("protocol version not support", zap.Stringer("wanted", p.config.Version), zap.Stringer("got", version))
return nil, ProtocolNotSupported
return conn, ProtocolNotSupported
}

if len(p.config.Keyspace) != 0 {
err = conn.SetKeyspace(ctx, p.config.Version, p.config.Keyspace)
if err != nil {
return nil, err
return conn, err
}
}

Expand Down