Skip to content

Fixed Sanity Issue in SMB file#120

Merged
sachin-apa merged 2 commits into
dell:mainfrom
meenakshidembi691:Sanity_issue_smb_file
Oct 14, 2024
Merged

Fixed Sanity Issue in SMB file#120
sachin-apa merged 2 commits into
dell:mainfrom
meenakshidembi691:Sanity_issue_smb_file

Conversation

@meenakshidembi691

Copy link
Copy Markdown
Contributor

Description

Fixed Sanity Issue in SMB filen

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, pep8, linting, or security issues
  • I have performed Ansible Sanity test using --docker default
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

@codecov-commenter

codecov-commenter commented Oct 11, 2024

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.87%. Comparing base (c5b1405) to head (2e4cc2c).
⚠️ Report is 136 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #120      +/-   ##
==========================================
+ Coverage   81.90%   82.87%   +0.96%     
==========================================
  Files         124      133       +9     
  Lines       13463    14476    +1013     
  Branches     1989     2132     +143     
==========================================
+ Hits        11027    11997     +970     
  Misses       1830     1830              
- Partials      606      649      +43     
Flag Coverage Δ
units 82.87% <100.00%> (+0.96%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sachin-apa sachin-apa merged commit a0fc3a6 into dell:main Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants