Skip to content

Improve Code Coverage for Group module#171

Merged
taohe1012 merged 1 commit into
mainfrom
group-coverage-increase
Apr 1, 2025
Merged

Improve Code Coverage for Group module#171
taohe1012 merged 1 commit into
mainfrom
group-coverage-increase

Conversation

@taohe1012

@taohe1012 taohe1012 commented Mar 28, 2025

Copy link
Copy Markdown
Contributor

Description

Improve Code Coverage for Group module
image

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, pep8, linting, or security issues
  • I have performed Ansible Sanity test using --docker default
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • UT

@taohe1012 taohe1012 requested review from RayLiu7, baoy1 and vangork March 28, 2025 07:01
@codecov-commenter

codecov-commenter commented Mar 28, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.89%. Comparing base (1af13a5) to head (ac02f21).
⚠️ Report is 37 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #171      +/-   ##
==========================================
+ Coverage   88.84%   89.89%   +1.04%     
==========================================
  Files         145      145              
  Lines       16400    16583     +183     
  Branches     2341     2366      +25     
==========================================
+ Hits        14571    14907     +336     
+ Misses       1156     1007     -149     
+ Partials      673      669       -4     
Flag Coverage Δ
units 89.89% <100.00%> (+1.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@taohe1012 taohe1012 force-pushed the group-coverage-increase branch 4 times, most recently from 9bc9d11 to c79137f Compare March 28, 2025 12:52
@taohe1012 taohe1012 marked this pull request as ready for review March 28, 2025 13:05
@taohe1012 taohe1012 force-pushed the group-coverage-increase branch from c79137f to b5bafae Compare March 31, 2025 05:42
baoy1
baoy1 previously approved these changes Mar 31, 2025
@taohe1012 taohe1012 force-pushed the group-coverage-increase branch 3 times, most recently from b42a444 to 8b2567f Compare March 31, 2025 12:50
@taohe1012 taohe1012 force-pushed the group-coverage-increase branch from e75301d to ac02f21 Compare April 1, 2025 02:45
@taohe1012 taohe1012 merged commit bbb268d into main Apr 1, 2025
@taohe1012 taohe1012 deleted the group-coverage-increase branch April 1, 2025 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants