Skip to content

Fix mismatch of FileSystem ads owner#177

Merged
P-Cao merged 2 commits into
mainfrom
usr/p_cao/fix-fs-ads-owner-mismatch
May 15, 2025
Merged

Fix mismatch of FileSystem ads owner#177
P-Cao merged 2 commits into
mainfrom
usr/p_cao/fix-fs-ads-owner-mismatch

Conversation

@P-Cao

@P-Cao P-Cao commented May 14, 2025

Copy link
Copy Markdown
Contributor

Description

Now use sid to set owner of FilsSystem

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
#174

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, pep8, linting, or security issues
  • I have performed Ansible Sanity test using --docker default
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

FT pass and no regression issue:
https://osj-sio-03-prd.cec.lab.emc.com/job/ansible-pipelines/job/ans-ft-run/255/FT_20Report

@codecov-commenter

codecov-commenter commented May 14, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.25%. Comparing base (f402b1b) to head (d657741).
⚠️ Report is 43 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #177      +/-   ##
==========================================
- Coverage   90.26%   90.25%   -0.02%     
==========================================
  Files         143      143              
  Lines       16541    16544       +3     
  Branches     2365     2365              
==========================================
+ Hits        14930    14931       +1     
- Misses        941      942       +1     
- Partials      670      671       +1     
Flag Coverage Δ
units 90.25% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread plugins/modules/filesystem.py Outdated
Comment thread plugins/modules/filesystem.py Outdated
@P-Cao P-Cao force-pushed the usr/p_cao/fix-fs-ads-owner-mismatch branch from 65bafb6 to d657741 Compare May 15, 2025 08:57
@P-Cao P-Cao merged commit 66135f6 into main May 15, 2025
19 checks passed
@P-Cao P-Cao deleted the usr/p_cao/fix-fs-ads-owner-mismatch branch May 15, 2025 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants